Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Combobox list incorrect focus state placement and color contrast #12941

Open
2 tasks done
satyaminnekanti opened this issue Jan 10, 2023 · 2 comments
Open
2 tasks done

Comments

@satyaminnekanti
Copy link

Package

carbon-components

Browser

Chrome

Package version

v10

React version

No response

Description

Accessibility Issues with Combo-box:

Go to combo-box sample
select an Option (Option 2)
with an Option selected, open the combo-box options and navigate through them

  1. Issue 1: Focus not visible/shown clearly when navigated to currently selected item in combo ( i meant there is no colour change to indicate that the currently selected item received focus). This is a failure of WCAG Checkpoint 2.4.7. Focus Visible
  2. Issue 2: Also in combo-box once an option is selected and user navigated back to combo-box again and press down arrow, focus should be on the currently selected option and when user press Down Arrow key again focus should go to the next option after the selected but instead it always start from the top

Please see attached Gif:
ezgif com-gif-maker

Please refer ARIA Authoring Practices Guide for Combo-box for reference

Suggested Severity

Severity 2 = User cannot complete task, and/or no workaround within the user experience of a given component.

Reproduction/example

https://react.carbondesignsystem.com/?path=/story/components-combobox--default

Steps to reproduce

Steps to reproduce:

  1. Go to combo-box sample
  2. select an Option (Option 2)
  3. with an Option selected, open the combo-box options and navigate through them

Issues:

  1. Issue 1: Focus not visible/shown clearly when navigated to currently selected item in combo ( i meant there is no colour change to indicate that the currently selected item received focus). This is a failure of WCAG Checkpoint 2.4.7. Focus Visible
  2. Issue 2: Also in combo-box once an option is selected and user navigated back to combo-box again and press down arrow, focus should be on the currently selected option and when user press Down Arrow key again focus should go to the next option after the selected but instead it always start from the top

Please see attached Gif:
ezgif com-gif-maker

Please refer ARIA Authoring Practices Guide for Combo-box for reference

Code of Conduct

@tay1orjones
Copy link
Member

tay1orjones commented Jan 18, 2023

Thanks for reporting this! #1 is a duplicate of #12720 and #12723

@mbgower For #2, should the focus always be placed on the currently selected item as being suggested here? Does always placing the focus on the first item in the list fail any WCAG success criterion

@tay1orjones tay1orjones changed the title [Bug]: [Bug]: Combobox list incorrect focus state placement and color contrast Jan 18, 2023
@tay1orjones tay1orjones moved this to 🕵️‍♀️ Triage in Design System Jan 18, 2023
@tay1orjones
Copy link
Member

should the focus always be placed on the currently selected item as being suggested here? Does always placing the focus on the first item in the list fail any WCAG success criterion

Based on internal conversations, yes this should be the case. The actionable piece of this issue is to address the focus behavior when reopening the ComboBox after having selected an option. Focus should be placed on the selected option, not the first option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

2 participants