Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Read-only inputs]: Toggle implementation #12407

Closed
6 tasks
Tracked by #12241
sstrubberg opened this issue Oct 26, 2022 · 1 comment · Fixed by #12402
Closed
6 tasks
Tracked by #12241

[Read-only inputs]: Toggle implementation #12407

sstrubberg opened this issue Oct 26, 2022 · 1 comment · Fixed by #12402
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: toggle needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡 version: 11 Issues pertaining to Carbon v11

Comments

@sstrubberg
Copy link
Member

sstrubberg commented Oct 26, 2022

Reference #12241

image

image

Acceptance Criteria

  • Coded component in /package/react
  • Add a prop for read-only, add styles for said prop
  • Controls for each state in playground
  • Default story for easy copy and paste
  • RTL tests for the read-only class on the prop
  • When a toggle is readonly and not disabled, the field is read by screenreaders while not allowing the value to be changed.
@sstrubberg sstrubberg added adopter: DSAG adopter: PAL Work-stream that directly helps a Pattern & Asset Library. needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. component: toggle package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡 and removed status: needs triage 🕵️‍♀️ labels Oct 26, 2022
@sstrubberg sstrubberg moved this to Backlog in Roadmap Oct 26, 2022
@sstrubberg sstrubberg moved this from Backlog to Read-only Inputs in Roadmap Oct 26, 2022
@sstrubberg sstrubberg changed the title [Read only inputs]: Toggle implementation [Read-only inputs]: Toggle implementation Oct 26, 2022
@laurenmrice
Copy link
Member

Just noting here: For the Off read-only state, the text color of the Off label should be $text-primary and not $text-placeholder because it still needs to pass 4.5:1.

@kodiakhq kodiakhq bot closed this as completed in #12402 Nov 14, 2022
@kodiakhq kodiakhq bot moved this to ✅ Done in Design System Nov 14, 2022
Repository owner moved this from 2022-Q4 Read-only Inputs to Not pursuing in Roadmap Nov 14, 2022
@sstrubberg sstrubberg added the version: 11 Issues pertaining to Carbon v11 label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: toggle needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants