Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Accordion various bugs against website spec. lg content not middle aligned, hover color not $background-hover #12141

Closed
2 tasks done
shixiedesign opened this issue Sep 23, 2022 · 0 comments · Fixed by #12148
Closed
2 tasks done

[Bug]: Accordion various bugs against website spec. lg content not middle aligned, hover color not $background-hover #12141

shixiedesign opened this issue Sep 23, 2022 · 0 comments · Fixed by #12148
Assignees
@tw15egan
Labels
type: bug 🐛

Comments

@shixiedesign
Copy link
Contributor

shixiedesign commented Sep 23, 2022 •
edited
Loading

Package

@carbon/react

Browser

Chrome

Package version

1.13.0

Description

Two bugs against the specs on Carbon website.

  1. Size lg, in React storybook shows content top aligned, where as on website, spec shows content should be middle aligned (vertically centered):

image

2. Headers on hover color changes to `layer-hover`, while website spec states this should be `$background-hover`. Also happening in Figma kit, visible most in gray100 theme.

image

image

Reproduction/example

https://react.carbondesignsystem.com/?path=/story/components-accordion--playground&args=size:lg

Steps to reproduce

  1. Go to https://react.carbondesignsystem.com/?path=/story/components-accordion--playground&args=size:lg
  2. Set accordion size to lg
  3. See bug

Code of Conduct
@shixiedesign shixiedesign changed the title [Bug]: Accordion lg content not middle aligned but website is [Bug]: Accordion various bugs against website spec. lg content not middle aligned, hover color not $background-hover Sep 23, 2022
@tw15egan tw15egan self-assigned this Sep 23, 2022
This was referenced Sep 23, 2022
Merged
Merged
@kodiakhq kodiakhq bot closed this as completed in #12148 Oct 6, 2022
@kodiakhq kodiakhq bot moved this to ✅ Done in Design System Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

Labels
type: bug 🐛
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Accordion): update Accordion styles to match spec tw15egan/carbon
2 participants
@tw15egan @shixiedesign