Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Toggle click behavior #12117

Closed
2 tasks done
sstrubberg opened this issue Sep 20, 2022 · 2 comments · Fixed by #12212
Closed
2 tasks done

[Bug]: Toggle click behavior #12117

sstrubberg opened this issue Sep 20, 2022 · 2 comments · Fixed by #12212
Labels

Comments

@sstrubberg
Copy link
Member

Package

@carbon/react

Browser

Chrome

Package version

Storybook

React version

No response

Description

toggle busted

Checkout storybook. You can toggle it from anywhere in the white space

Reproduction/example

n/a

Steps to reproduce

n/a

Code of Conduct

@tay1orjones
Copy link
Member

tay1orjones commented Sep 21, 2022

This surfaced in slack.

This isn't a defect with the component itself, just with the story. We need to make the containing element that houses the label and toggle not span the entire width of the story so it behaves as you would expect: only clicking on the toggle or label makes the toggle switch.

@tay1orjones tay1orjones added severity: 4 https://ibm.biz/carbon-severity and removed severity: 4 https://ibm.biz/carbon-severity labels Sep 21, 2022
@renmaddox
Copy link

I believe this is only partly true. If the label is appreciably longer than the toggle control, including the state label, then the problem still exists regardless of container.

@kodiakhq kodiakhq bot closed this as completed in #12212 Oct 6, 2022
Repository owner moved this from ⏱ Backlog to ✅ Done in Design System Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants