From 30a214420ac8b8976677399d1db86d29c70600f4 Mon Sep 17 00:00:00 2001
From: Danilo Egea Gondolfo <danilogondolfo@gmail.com>
Date: Tue, 1 Oct 2024 11:23:20 +0100
Subject: [PATCH] config_fuzzer: run generate -i against the entire dataset

Now that the datalist was replaced with hash tables, run the generator
with --ignore-errors against the entire dataset. The datalist was
leaking memory and causing ASAN to crash the test.
---
 tests/config_fuzzer/runner.sh | 39 +++++++++++++++++------------------
 1 file changed, 19 insertions(+), 20 deletions(-)

diff --git a/tests/config_fuzzer/runner.sh b/tests/config_fuzzer/runner.sh
index e5b9ff15b..b1c02a8b0 100644
--- a/tests/config_fuzzer/runner.sh
+++ b/tests/config_fuzzer/runner.sh
@@ -121,29 +121,28 @@ echo "$(date) - Done"
 
 echo "$(date) - Running netplan generate -i"
 
-for yaml in ${FAKEDATADIR}/*.yaml
-do
-    rm -rf fakeroot3
-    mkdir -p fakeroot3/etc/netplan
-    cp ${yaml} fakeroot3/etc/netplan/
+# Run the generator against the entire dataset
 
-    OUTPUT=$(${NETPLAN_GENERATE_PATH} --root-dir fakeroot3 -i 2>&1)
-    code=$?
-    if [ $code -eq 139 ] || [ $code -eq 245 ] || [ $code -eq 133 ]
-    then
-        echo "GENERATE --ignore-errors CRASHED"
-        cat ${yaml}
-        error=1
-    fi
+rm -rf fakeroot3
+mkdir -p fakeroot3/etc/
+mv ${FAKEDATADIR} fakeroot3/etc/netplan
 
-    if grep 'detected memory leaks' <<< "$OUTPUT" > /dev/null
-    then
-        echo "GENERATE --ignore-errors MEMORY LEAK DETECTED"
-        cat ${yaml}
-        error=1
-    fi
+OUTPUT=$(${NETPLAN_GENERATE_PATH} --root-dir fakeroot3 -i 2>&1)
+code=$?
+# code 134 happens when a g_assert() is triggered
+if [ $code -eq 139 ] || [ $code -eq 245 ] || [ $code -eq 133 ] || [ $code -eq 134 ]
+then
+    echo "GENERATE --ignore-errors CRASHED"
+    cat ${yaml}
+    error=1
+fi
 
-done
+if grep 'detected memory leaks' <<< "$OUTPUT" > /dev/null
+then
+    echo "GENERATE --ignore-errors MEMORY LEAK DETECTED"
+    cat ${yaml}
+    error=1
+fi
 
 echo "$(date) - Done"