From a93996829b82d29efb4872d889090aeb44efac98 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Przemys=C5=82aw=20Suliga?= Date: Wed, 4 Dec 2024 14:31:05 +0100 Subject: [PATCH] Stop using TaliskerRequestsTransport At least for now stop using the TaliskerRequestsTransport. In practice, for flask apps it was not used in the apps/workers because FlaskSentry was explicitly setting a None 'transport' in the client kwargs. This change makes sure that the same default raven (threaded) transport is used by logging in the main process. This will mitigate the deadlocks described in https://github.com/prometheus/client_python/pull/1076#issuecomment-2513729120 because there will be no prometheus instrumentation for sentry requests. --- talisker/sentry.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/talisker/sentry.py b/talisker/sentry.py index 12fa1e60..4e0bc9e5 100644 --- a/talisker/sentry.py +++ b/talisker/sentry.py @@ -317,9 +317,6 @@ def ensure_talisker_config(kwargs): processors = set(kwargs.get('processors') or []) kwargs['processors'] = list(default_processors | processors) - if 'transport' not in kwargs: - kwargs['transport'] = TaliskerRequestsTransport - # note: style clash - sentry client api is 'sanitize_keys' sanitise_keys = kwargs.get('sanitize_keys', []) if sanitise_keys is None: # flask integration explicitly sets None