Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new dapr component params. #150

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

runefa
Copy link
Collaborator

@runefa runefa commented Sep 1, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@runefa runefa changed the title Added new dapr compononet params. Added new dapr component params. Sep 1, 2022
Copy link
Collaborator

@StrawnSC StrawnSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a few things:

  • History file entry
  • Linter issues?
  • Style

I'll respond with a more substantive review once I try it out

@StrawnSC StrawnSC self-requested a review September 2, 2022 21:04
Copy link
Collaborator

@StrawnSC StrawnSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the points above, LGTM

@runefa runefa merged commit 512fa62 into calvinsID:containerapp-0.3.11 Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants