Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the Docker image built by GitHub Actions behaves similar to one built locally #391

Closed
angela-tran opened this issue Dec 19, 2023 · 1 comment · Fixed by #392
Closed
Assignees
Labels
bug Something isn't working

Comments

@angela-tran
Copy link
Member

angela-tran commented Dec 19, 2023

After troubleshooting and fixing the issue causing our Azure app service to not start (see #389 and #390), I noticed the version in the app service's Docker container is not correct. I then realized a huge potential reason why I haven't been able to reproduce any of the problems: I was testing with a Docker image that I locally built, and Azure is using one built by our GitHub Action!

I downloaded the image from GHCR and see the same incorrect version.

Looking at the workflow logs, I see there is a warning about a shallow copy. This issue seems relevant: pypa/setuptools-scm#414

@angela-tran angela-tran added the bug Something isn't working label Dec 19, 2023
@angela-tran angela-tran self-assigned this Dec 19, 2023
@angela-tran angela-tran moved this from Todo to In Progress in Digital Services Dec 19, 2023
@angela-tran angela-tran changed the title Ensure the Docker container built by GitHub Actions behaves similar to one built locally Ensure the Docker image built by GitHub Actions behaves similar to one built locally Dec 19, 2023
@angela-tran
Copy link
Member Author

Here's the log from Azure:

2023-12-19T21:34:56.004063843Z + bin/init.sh
2023-12-19T21:34:56.029409239Z + flask init-db
2023-12-19T21:35:01.071354056Z SENTRY_DSN not set, so won't send events
2023-12-19T21:35:01.090299054Z [2023-12-19 21:35:01,071] INFO eligibility_server.app:31 Starting Eligibility Server 0.1.dev1+g96e8f16

You can see it doesn't see any of our annotated tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant