Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended changes resulting from automated audit #98

Closed
1 of 2 tasks
Jericho opened this issue Apr 20, 2019 · 1 comment
Closed
1 of 2 tasks

Recommended changes resulting from automated audit #98

Jericho opened this issue Apr 20, 2019 · 1 comment
Assignees
Milestone

Comments

@Jericho
Copy link
Member

Jericho commented Apr 20, 2019

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

  • You are currently referencing Cake.Core 0.28.0. Please upgrade to 0.33.0
  • The nuget package for your addin should use the cake-contrib icon. Specifically, your addin's .csproj should have a line like this: <PackageIconUrl>https://cdn.jsdelivr.net/gh/cake-contrib/graphics/png/cake-contrib-medium.png</PackageIconUrl>.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.

This issue was created by a tool: Cake.AddinDiscoverer version 3.12.1

@pascalberger pascalberger self-assigned this Apr 20, 2019
@pascalberger pascalberger added this to the vNext milestone Apr 20, 2019
@pascalberger
Copy link
Member

First point was fixed with #100

The icon already uses jsDelivr, but I prefer to keep the hash in there to not have the break the icon if the file is moved inside the repo, and update the file manually in case the icon changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants