Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing a sequence advance button many times in a row causes the next sequence to be completed as well #18

Closed
anbjoernskov opened this issue Nov 28, 2023 · 2 comments

Comments

@anbjoernskov
Copy link

Found a bug, that is maybe not so common, but very annoying when it happens.

I have a sequence that is advancing with the A button (but guess it could be any button). And there is an advance delay on that sequence, as I have some animation that needs to finish.

I accidentally press multiple times on the advanced button (like frenzy), but it caused the next two sequences to just scroll by.

I think this part of the code is the culprit:
image

Also a bit hard to debug, but I put a break point in the finishSequence, and it is indeed being called several times.

So I guess a check should be made, if it is already advancing, and then only do the performAfterDelay once.

@anbjoernskov
Copy link
Author

Btw - my advance delay is fairly long 3500 ms, so maybe that is why it is happening to me, as it actually manages to transition to the next sequence, before it is retriggered

@cadin
Copy link
Owner

cadin commented Dec 2, 2023

Fixed in 1.7.2

@cadin cadin closed this as completed Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants