Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on previous versions of Go #2486

Closed
erbesharat opened this issue Feb 26, 2019 · 3 comments
Closed

Build fails on previous versions of Go #2486

erbesharat opened this issue Feb 26, 2019 · 3 comments

Comments

@erbesharat
Copy link

1. Which version of Caddy are you using (caddy -version)?

Caddy (untracked dev build) (unofficial)
72d0deb

2. What are you trying to do?

The latest changes on 72d0deb will break the builds that use previous versions of Go. (only works on 1.12)
These changes caused our tests to fail too. For more information you can check: https://travis-ci.org/txtdirect/txtdirect/jobs/498581871

3. What is your Caddyfile?

example.test:8080, tor.example.test:8080, pkg.example.test:8080, host.example.test:8080, gomods.example.test:8080, gometa.example.test:8080 {
    tls off
    txtdirect {
        enable path host tor gometa gomods dockerv2 proxy
        resolver 127.0.0.1:5353
				logfile stdout
				redirect 192.168.1.3
        prometheus {
            address localhost:6985
        }
        gomods {
            cache
        }
    }
    log / stdout "{remote} - [{when_iso}] \"{method} {uri} {proto}\" {status} {size} {latency}"
    errors stdout
}

4. How did you run Caddy (give the full command and describe the execution environment)?

I used our custom build that injects our plugin to caddy. (Don't think its needed but can post the build process too)

5. Please paste any relevant HTTP request(s) here.

6. What did you expect to see?

Not fail and work fine on previous versions

7. What did you see instead (give full error messages and/or log)?

Fails on previous Go versions.

8. Why is this a bug, and how do you think this should be fixed?

It's bug because it causes builds on previous versions to fail. Not sure how you can handle this and fix it.

9. What are you doing to work around the problem in the meantime?

Using previous versions of caddy

10. Please link to any related issues, pull requests, and/or discussion.

#2399, 72d0deb

@uberswe
Copy link

uberswe commented Feb 26, 2019

I guess I am upgrading to go 1.12.

What is recommended if we do not want to upgrade, should we simply build the latest release from source? Is there an easy way to specify a version number when building from source?

@abiosoft
Copy link

Go 1.12 is now a requirement to build Caddy. #2080 (comment).

To use an older version of Go, you would have to stick with an older version of Caddy as well.

@abiosoft
Copy link

I guess I am upgrading to go 1.12.

What is recommended if we do not want to upgrade, should we simply build the latest release from source? Is there an easy way to specify a version number when building from source?

If you download at caddyserver.com/download, you'd get the latest release.
When building from source, you can always checkout a specific revision or release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants