Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit oncoprinter implementation #9500

Closed
2 tasks done
dippindots opened this issue May 2, 2022 · 3 comments
Closed
2 tasks done

Revisit oncoprinter implementation #9500

dippindots opened this issue May 2, 2022 · 3 comments
Assignees

Comments

@dippindots
Copy link
Member

dippindots commented May 2, 2022

There are two existing issues that need to be investigated

  • mutation type is different than results view oncoprint
  • end position is different than results view oncoprint
@dippindots
Copy link
Member Author

dippindots commented May 4, 2022

Oncoprinter: Protein start position and protein end position are calculated by our util function: getProteinPositionFromProteinChange. getProteinPositionFromProteinChange function takes a proteinChange string and parse it, then get protein start position and protein end position from it.

Results view Oncoprint: data is coming from mutations endpoint, and data should come from mutations endpoint

e.g. this mutation
image

@dippindots
Copy link
Member Author

Logic for mutation type mapping from results view oncoprint to oncoprinter:

    switch (type) {
        case 'missense_mutation':
        case 'missense':
        case 'missense_variant':
            ret = 'missense';
            break;
        case 'frame_shift_ins':
        case 'frame_shift_del':
        case 'frameshift':
        case 'frameshift_deletion':
        case 'frameshift_insertion':
        case 'de_novo_start_outofframe':
        case 'frameshift_variant':
            ret = 'frameshift';
            break;
        case 'nonsense_mutation':
        case 'nonsense':
        case 'stopgain_snv':
            ret = 'nonsense';
            break;
        case 'splice_site':
        case 'splice':
        case 'splice site':
        case 'splicing':
        case 'splice_site_snp':
        case 'splice_site_del':
        case 'splice_site_indel':
        case 'splice_region':
            ret = 'splice';
            break;
        case 'translation_start_site':
        case 'start_codon_snp':
        case 'start_codon_del':
            ret = 'nonstart';
            break;
        case 'nonstop_mutation':
            ret = 'nonstop';
            break;
        case 'fusion':
            ret = 'fusion';
            break;
        case 'in_frame_del':
        case 'in_frame_ins':
        case 'in_frame_deletion':
        case 'in_frame_insertion':
        case 'indel':
        case 'nonframeshift_deletion':
        case 'nonframeshift':
        case 'nonframeshift insertion':
        case 'nonframeshift_insertion':
            ret = 'inframe';
            break;
        default:
            ret = 'other';
            break;
    }

@dippindots
Copy link
Member Author

dippindots commented May 6, 2022

Close this and open related issues: genome-nexus/genome-nexus#612 cBioPortal/icebox#501 cBioPortal/icebox#330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant