-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update e2e tests to use CANCER_TYPE rather than tumor type #11321
Comments
Hey @inodb , I can take this on. I’ll update the end-to-end tests for scatter plots, box plots, and waterfall plots to use the hardcoded I'll be grateful, if you could assign this issue to me? |
Thanks so much @Swayam-code ! We usually don't assign tickets outside of the core contributor team, so please go ahead. Nobody else is working on it |
Glad to work on this issue. |
@inodb @rishisulakhe i guess we should assume that the screeshots will be need to be updated because of the colors, right? |
@alisman yes |
There are several end-to-end tests that color scatter plots based on tumor type:
See e.g.
plots_tab_box_plot_color_by_tumor_type_highlight_categories
:From: https://output.circle-artifacts.com/output/job/95bd19f2-0b4e-4cc5-beab-bb20a9ec0996/artifacts/0/imageCompare.html
These don't have defined colors so the colors can change randomly. The CANCER_TYPE attribute has hardcoded colors, see e.g. AML:
from https://oncotree.info
Let's use that instead for testing
The text was updated successfully, but these errors were encountered: