From 0a337c5875b9aa0d4196ef2f193d9a1f5ad853b5 Mon Sep 17 00:00:00 2001
From: Bas Leenknegt <basleenknegt@thehyve.nl>
Date: Tue, 21 Mar 2023 10:51:53 +0100
Subject: [PATCH] Expect submit button only when filter queued in autosubmit
 toggle e2e tests

---
 .../study-view-filters-autocommit-toggle.spec.js  | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/end-to-end-test/local/specs/study-view-filters-autocommit-toggle.spec.js b/end-to-end-test/local/specs/study-view-filters-autocommit-toggle.spec.js
index bf162ebad2d..e91015be36b 100644
--- a/end-to-end-test/local/specs/study-view-filters-autocommit-toggle.spec.js
+++ b/end-to-end-test/local/specs/study-view-filters-autocommit-toggle.spec.js
@@ -9,7 +9,8 @@ const SELECT_SAMPLES_BUTTON = 'button=Select Samples';
 const ADD_FILTERS_BUTTON = 'button=Add Filters';
 const STUDY_VIEW_HEADER = `div[data-test="study-view-header"]`;
 const SETTINGS_MENU_BUTTON = `button[data-test="study-view-settings-menu"]`;
-const DISABLE_AUTOCOMMIT_FIELD = `label=Manually submit`;
+const MANUALLY_COMMIT_RADIO = `input[name="hesitateMode"][value="manual"]`;
+const AUTOCOMMIT_RADIO = `input[name="hesitateMode"][value="auto"]`;
 const SUBMIT_STUDY_FILTERS = `button[data-test="submit-study-filters"]`;
 const PUTATIVE_PROFILE =
     "//span[text() = 'Putative copy-number alterations from GISTIC']";
@@ -31,12 +32,15 @@ describe.only('Toggling of study view filters autosubmit', function() {
     });
 
     it('can disable filter submission in settings menu', () => {
-        $(SETTINGS_MENU_BUTTON).waitForDisplayed({ timeout: 20000 });
+        $(SETTINGS_MENU_BUTTON).waitForDisplayed({ timeout: 5000 });
         $(SETTINGS_MENU_BUTTON).click();
-        $(DISABLE_AUTOCOMMIT_FIELD).waitForDisplayed({ timeout: 20000 });
-        $(DISABLE_AUTOCOMMIT_FIELD).click();
+        $(AUTOCOMMIT_RADIO).waitForDisplayed({ timeout: 5000 });
+        assert($(AUTOCOMMIT_RADIO).isSelected());
 
-        assert($(SUBMIT_STUDY_FILTERS).isDisplayed());
+        $(MANUALLY_COMMIT_RADIO).click();
+
+        assert($(MANUALLY_COMMIT_RADIO).isSelected());
+        assert(!$(AUTOCOMMIT_RADIO).isSelected());
     });
 
     it('queues new filters when autosubmit disabled', () => {
@@ -45,6 +49,7 @@ describe.only('Toggling of study view filters autosubmit', function() {
 
         const queuedFilterInHeader = $(STUDY_VIEW_HEADER).$(LOG2_PROFILE);
         assert(queuedFilterInHeader.isDisplayed());
+        assert($(SUBMIT_STUDY_FILTERS).isDisplayed());
         const isFilterQueued = hasFilterClass(queuedFilterInHeader, 'pending');
         assert(isFilterQueued);
     });