Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

legend ignores reverseData #44

Open
minusf opened this issue Jan 23, 2019 · 3 comments
Open

legend ignores reverseData #44

minusf opened this issue Jan 23, 2019 · 3 comments

Comments

@minusf
Copy link
Collaborator

minusf commented Jan 23, 2019

https://github.com/gionkunz/chartist-js/issues/508

reverseData: true reverses not only the list elements, but also the lists themselves insides series. This might be logical for some, it is not logical for me.

In any case this messes up the order of widget.legend.

I am not including any patches because the whole reverseData feature needs mental gymnastics that is not worth the effort for me with possible side effects like this.

I am not sure this should be turned on by default.
@byashimov
Copy link
Owner

Sorry, minusf. Pull request or I'will leave it as is :)

@minusf
Copy link
Collaborator Author

minusf commented Jan 26, 2019

At least the documentation should mention this. I will come up with a diff for that.

@byashimov
Copy link
Owner

Thanks for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@byashimov @minusf