Skip to content

Commit

Permalink
fix: fix event handler remover on IE11
Browse files Browse the repository at this point in the history
closes #10
  • Loading branch information
3cp committed Mar 26, 2019
1 parent d324e7a commit 5ccabc5
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/dnd-service.js
Original file line number Diff line number Diff line change
Expand Up @@ -311,11 +311,11 @@ class DndService {
this._drag = this._drag.bind(this);

// dnd start handler on doc level
documentElement.addEventListener('mousedown', this._grab, {passive: false});
documentElement.addEventListener('mousedown', this._grab);
documentElement.addEventListener('touchstart', this._grab, {passive: false});

// dnd end handler for desktop on doc level
documentElement.addEventListener('mouseup', this._release, {passive: false});
documentElement.addEventListener('mouseup', this._release);
// dnd end handler for mobile (touch event) on source element
}

Expand Down Expand Up @@ -366,7 +366,7 @@ class DndService {
}

_startListeningEventualMovements () {
documentElement.addEventListener('mousemove', this._startBecauseMouseMoved, {passive: false});
documentElement.addEventListener('mousemove', this._startBecauseMouseMoved);
this._element && this._element.addEventListener('touchmove', this._startBecauseMouseMoved, {passive: false});

// dnd end handler for mobile (touch event) on source element
Expand All @@ -375,14 +375,14 @@ class DndService {

_stopListeningEventualMovements () {
documentElement.removeEventListener('mousemove', this._startBecauseMouseMoved);
this._element && this._element.removeEventListener('touchmove', this._startBecauseMouseMoved);
this._element && this._element.removeEventListener('touchmove', this._startBecauseMouseMoved, {passive: false});
}

_startListeningMovements() {
documentElement.addEventListener('selectstart', this._preventGrabbed); // IE8
documentElement.addEventListener('click', this._preventGrabbed);

documentElement.addEventListener('mousemove', this._drag, {passive: false});
documentElement.addEventListener('mousemove', this._drag);
this._element && this._element.addEventListener('touchmove', this._drag, {passive: false});
}

Expand All @@ -391,9 +391,9 @@ class DndService {
documentElement.removeEventListener('click', this._preventGrabbed);

documentElement.removeEventListener('mousemove', this._drag);
this._element && this._element.removeEventListener('touchmove', this._drag);
this._element && this._element.removeEventListener('touchmove', this._drag, {passive: false});
// remove dnd end handler for mobile (touch event) on source element
this._element && this._element.removeEventListener('touchend', this._release);
this._element && this._element.removeEventListener('touchend', this._release, {passive: false});
}

_preventGrabbed(e) {
Expand Down

0 comments on commit 5ccabc5

Please sign in to comment.