Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include rectangle #16

Closed
kkmuffme opened this issue Dec 18, 2018 · 3 comments
Closed

include rectangle #16

kkmuffme opened this issue Dec 18, 2018 · 3 comments

Comments

@kkmuffme
Copy link

You already have a exclude rectangle option.

It would be great if the inverse would be possible too: include rectangle. Sometimes I want to compare only a specific part/rectangle of the screenshot, so it would be really helpful if I only have to define the include instead of having to exclude everything else.

burnpiro added a commit that referenced this issue Dec 30, 2018
Implementation of new matching function
burnpiro added a commit that referenced this issue Dec 30, 2018
@burnpiro
Copy link
Owner

burnpiro commented Dec 30, 2018

I've implemented part on my side and created PR for node-reasemble-js library:
lksv/node-resemble.js#46
There is also issue involved in this:
lksv/node-resemble.js#45

I'll merge my changes after he/they will merge my PR 😞

Sorry it took so long but there was whole Christmass and staff 🎅 , if you want to check new README take a look https://github.com/burnpiro/puppeteer-screenshot-tester/blob/be0a297817c7699e69775cb58248d6f834846faf/README.md

@kkmuffme
Copy link
Author

Perfect, thanks!

@burnpiro
Copy link
Owner

Resolved in Release 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants