Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set a lastModified time on incident creation #1618

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

srabraham
Copy link
Member

this is a necessary followup to
#1616

prior to this PR, new incident creation would fail on converting a None datetime

this is a necessary followup to
#1616

prior to this PR, new incident creation would fail on converting
a None datetime
@srabraham srabraham enabled auto-merge (squash) February 27, 2025 16:57
@srabraham srabraham merged commit 3ad86b2 into master Feb 27, 2025
12 checks passed
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.36%. Comparing base (43eea80) to head (b05e2ab).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ims/application/_api.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1618      +/-   ##
==========================================
+ Coverage   70.34%   70.36%   +0.01%     
==========================================
  Files         188      188              
  Lines        9379     9380       +1     
  Branches     1519     1519              
==========================================
+ Hits         6598     6600       +2     
  Misses       2665     2665              
+ Partials      116      115       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srabraham srabraham deleted the srabraham-2025-02-27-lastmod branch February 27, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant