fully swap over to async/await in JavaScript #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also use the standard Fetch API rather than jquery ajax This was a pretty big change, but it makes the code a lot simpler. The callbacks within callbacks within callbacks were a nightmare when trying to reason through the code. async/await lets you pretty much just read top to bottom. I opted against throwing errors (/using Promise.reject) in favor of returning errors instead. It's prettier than having try-catches all over the place, or maybe that's just my opinion as a Gopher. #1602
ece4d1a to
c56e232
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1604 +/- ##
==========================================
- Coverage 70.11% 70.09% -0.03%
==========================================
Files 188 188
Lines 9334 9334
Branches 1516 1516
==========================================
- Hits 6545 6543 -2
- Misses 2675 2676 +1
- Partials 114 115 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also use the standard Fetch API rather than jquery ajax
This was a pretty big change, but it makes the code a lot simpler. The callbacks within callbacks within callbacks were a nightmare when trying to reason through the code. async/await lets you pretty much just read top to bottom.
I opted against throwing errors (/using Promise.reject) in favor of returning errors instead. It's prettier than having try-catches all over the place, or maybe that's just my opinion as a Gopher.
#1602