Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nag user to supply an incident type before closing an incident #1600

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

srabraham
Copy link
Member

unrelated thing: don't cache incident types when on the incident types admin page, since then new types don't show up after you add them.

fixes #199

unrelated thing: don't cache incident types when on the incident types admin page,
since then new types don't show up after you add them.

fixes #199
@srabraham srabraham force-pushed the srabraham-2025-01-31-search-re branch from 3516193 to f5c6c7a Compare February 12, 2025 19:04
@srabraham srabraham enabled auto-merge (squash) February 12, 2025 19:05
@srabraham srabraham merged commit a86c99b into master Feb 12, 2025
11 checks passed
@srabraham srabraham deleted the srabraham-2025-01-31-search-re branch February 12, 2025 19:11
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (a783843) to head (f5c6c7a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1600      +/-   ##
==========================================
- Coverage   70.11%   70.09%   -0.03%     
==========================================
  Files         188      188              
  Lines        9335     9335              
  Branches     1516     1516              
==========================================
- Hits         6545     6543       -2     
- Misses       2676     2677       +1     
- Partials      114      115       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require incident type prior to closing an incident
1 participant