remove "vintage" use, as it doesn't work #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vintage is no longer a Ranger status, so it never shows up. We could start reading the new Vintage attribute instead, but no one has asked for that yet. fixes #367
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1598 +/- ##
==========================================
- Coverage 70.11% 70.11% -0.01%
==========================================
Files 188 188
Lines 9337 9335 -2
Branches 1516 1516
==========================================
- Hits 6547 6545 -2
Misses 2676 2676
Partials 114 114 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vintage is no longer a Ranger status, so it never shows up. We could start reading the new Vintage attribute instead, but no one has asked for that yet.
fixes #367