add "lastModified" to Incident entity, add column in DataTable #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1589 +/- ##
==========================================
+ Coverage 70.09% 70.11% +0.01%
==========================================
Files 188 188
Lines 9317 9331 +14
Branches 1509 1515 +6
==========================================
+ Hits 6531 6542 +11
- Misses 2673 2674 +1
- Partials 113 115 +2 ☔ View full report in Codecov by Sentry. |
Before this change, we were figuring out last modification time on the client side. That was being calculated incorrectly, since we weren't passing system report entries into the Incidents view (exclude_system_entries = True). This moves over that computation to the server. Also, this adds a "Modified" column to the Incidents view. I'm theorizing that people might find this useful; possibly more useful than "Created". It could especially be useful as a sort order, so that active Incidents are at the top and older ones fall to the bottom. NOTE that if we want to remove this DataTables column in the future, we should still keep the server-side piece of this commit, and we should still use the new "last_modified" field in the API to know when an Incident was last modified. (finally, there's one little tweak in here for document titles, making them more concise)
e4a01da to
7030f41
Compare
wsanchez
reviewed
Feb 26, 2025
srabraham
added a commit
that referenced
this pull request
Feb 27, 2025
I'm not sure why I had it as optional before, but all the tests pass now with it being required. #1589 (comment)
srabraham
added a commit
that referenced
this pull request
Feb 27, 2025
I'm not sure why I had it as optional before, but all the tests pass now with it being required. #1589 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, we were figuring out last modification time on the client side. That was being calculated incorrectly, since we weren't passing system report entries into the Incidents view (exclude_system_entries = True). This moves over that computation to the server.
Also, this adds a "Modified" column to the Incidents view. I'm theorizing that people might find this useful; possibly more useful than "Created". It could especially be useful as a sort order, so that active Incidents are at the top and older ones fall to the bottom.
NOTE that if we want to remove this DataTables column in the future, we should still keep the server-side piece of this commit, and we should still use the new "last_modified" field in the API to know when an Incident was last modified.