Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to change "CNB_PLATFORM_EXPERIMENTAL_FEATURES" setting #947

Closed
jromero opened this issue Nov 10, 2020 · 1 comment
Closed
Labels
status/blocked Issue or PR that is blocked. See comments. type/enhancement Issue that requests a new feature or improvement.

Comments

@jromero
Copy link
Member

jromero commented Nov 10, 2020

Description

As per buildpacks/rfcs#115, we'll likely want to provide a mechanism to change the ability to tweak the CNB_PLATFORM_EXPERIMENTAL_FEATURES setting.

Proposed solution

A few options:

  • Add a flag to build (ie. --experimental={warn|silent|error})
  • Add an option to config.toml to globally set value
  • Roll it up into pack's existing experimental=true in config.toml to equal "silent" otherwise "error"

Additional context

We should make sure it's clear, if we separate them, that there is a distinction between pack and lifecycle experimental features.

@jromero jromero added type/enhancement Issue that requests a new feature or improvement. status/blocked Issue or PR that is blocked. See comments. labels Nov 10, 2020
@jjbustamante
Copy link
Member

Closing this one, we ended up implementing option 3 with this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/blocked Issue or PR that is blocked. See comments. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

No branches or pull requests

2 participants