Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Detect] Fail fast if buildpack.toml mixins are not satisfied by stack #578

Closed
natalieparellano opened this issue Apr 13, 2021 · 6 comments
Assignees
Labels
epic/stackpacks/phase-1 Reverse analyze & detect; analyze enhancements epic/stackpacks good first issue A good first issue to get started with. status/blocked status/ready type/enhancement New feature or request

Comments

@natalieparellano
Copy link
Member

natalieparellano commented Apr 13, 2021

By reading application buildpacks' buildpack.toml, the lifecycle can know what mixins are being statically requested.

The lifecycle can know what mixins are pre-installed on the stack by reading analyzed.toml.

Therefore, if all statically requested mixins are NOT satisfied by the stack, the lifecycle should fail.

@natalieparellano natalieparellano added epic/stackpacks epic/stackpacks/phase-1 Reverse analyze & detect; analyze enhancements labels Apr 13, 2021
@srisatya12
Copy link

I want to work on this issue.

@natalieparellano
Copy link
Member Author

@srisatya1197 that's awesome! This issue is currently blocked on the unresolved question here: #573

How should analyzed.toml be changed to include run-image information (mixins)

but we'll do our best to get it un-blocked as soon as possible.

Given that this issue is part of a larger epic that is currently taking shape, and thus requires a higher level of coordination, it would be great if you could join the discussion in our Slack #implementation channel.

@natalieparellano natalieparellano changed the title [Detect] Fail fast if buildpack.toml mixins are not satisfied [Analyze] Fail fast if buildpack.toml mixins are not satisfied Apr 20, 2021
@natalieparellano
Copy link
Member Author

As per discussion here: buildpacks/spec#197 (comment) this belongs in analyze, not detect.

@natalieparellano natalieparellano added the good first issue A good first issue to get started with. label Apr 29, 2021
@natalieparellano
Copy link
Member Author

Moving this back to detect, as each buildpack.toml won't be available to the analyzer.

@natalieparellano natalieparellano changed the title [Analyze] Fail fast if buildpack.toml mixins are not satisfied [Detect] Fail fast if buildpack.toml mixins are not satisfied Apr 30, 2021
@natalieparellano natalieparellano added this to the lifecycle-0.12.0 milestone May 10, 2021
@natalieparellano natalieparellano changed the title [Detect] Fail fast if buildpack.toml mixins are not satisfied [Detect] Fail fast if buildpack.toml mixins are not satisfied by stack Jun 14, 2021
@natalieparellano
Copy link
Member Author

Breaking this into two issues as 0.12.0 won't have knowledge of stackpacks.

@natalieparellano
Copy link
Member Author

Removing this from 0.12.0 milestone for the same reason as #573 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/stackpacks/phase-1 Reverse analyze & detect; analyze enhancements epic/stackpacks good first issue A good first issue to get started with. status/blocked status/ready type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants