Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isSequence output when changing input value #21

Merged
merged 2 commits into from
Dec 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/validators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ function inSequence(
if (r.type === "failure") {
return r;
}
input = r.success;
value = r.success;
}
return success(value);
};
Expand Down
44 changes: 44 additions & 0 deletions test/validators.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import { failure, isFailure, isSuccess, success } from "../src/Result";
import { validators } from "../src/validators";

describe("validators", () => {
describe("inSequence", () => {
test("it should succeed", async () => {
const result = await validators.inSequence(
validators.validator((a: string) => success(a)),
validators.validator((b: string) => success(b))
)("foo");

expect(isSuccess(result)).toBeTruthy();
});

test("it should fail", async () => {
const successValidator = validators.validator((a: string) => success(a));
const failValidator = validators.validator((b: string) => failure(b));

const result1 = await validators.inSequence(
successValidator,
failValidator
)("foo");

expect(isFailure(result1)).toBeTruthy();

const result2 = await validators.inSequence(
failValidator,
successValidator
)("foo");

expect(isFailure(result2)).toBeTruthy();
});

test("it should pass the validator output to the subsequent validator", async () => {
const validator1 = validators.validator((a: string) => success(a.length));
const validation = jest.fn((b: number) => success(b));
const validator2 = validators.validator(validation)

await validators.inSequence(validator1, validator2)("foo");

expect(validation).toHaveBeenCalledWith(3);
});
});
});