Fix isSequence output when changing input value #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giogonzo
reviewed
Dec 15, 2022
test/validators.test.ts
Outdated
|
|
||
| describe("validators", () => { | ||
| describe("inSequence", () => { | ||
| test("it should success validation", async () => { |
There was a problem hiding this comment.
maybe "succeed"? or just simply (since it's the first basic test for this validator):
Suggested change
| test("it should success validation", async () => { | |
| test("it should work", async () => { |
There was a problem hiding this comment.
failure test is also a "it should work" basic scenario isn't it? 😄 I'll go with "succeed"
giogonzo
approved these changes
Dec 15, 2022
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
I also added some extra tests for isSequence basic functionality (success and failure).