Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate typography values to particles #17

Open
james-nash opened this issue May 30, 2019 · 0 comments
Open

Migrate typography values to particles #17

james-nash opened this issue May 30, 2019 · 0 comments
Labels
design tokens CATEGORY: Anything related to creation or maintenance of Gravity's design tokens help wanted INVITATION: Indicates that a maintainer wants help on an issue or pull request 🌟 enhancement TYPE: Indicates new feature requests

Comments

@james-nash
Copy link

Is your feature request related to a problem? Please describe.
Currently, the SASS code in @buildit/gravity-ui-web defines a number of typography values that are used throughout the UI: Base font size, modular scale multipliers, default line-height, font family stack, etc.

They should be moved from there into this repo as design tokens. That way, we can begin to export and publish them into other formats to support platforms beyond just the web.

Describe the solution you'd like

  • Add new typography design tokens in this repo
  • Update the StyleDictionary config and scripts to export them as suitable SASS vars/maps/ whaetevr & TS vars (and anything else we migth support)
  • Update the gravity-ui-web repo to:
    • Depend on the new version of @buildit/gravity-particles that contains the typography values
    • Update the SASS code so that it no longer contains its own typography variable declarations and instead imports them from @buildit/gravity-particles.
@james-nash james-nash added 🌟 enhancement TYPE: Indicates new feature requests help wanted INVITATION: Indicates that a maintainer wants help on an issue or pull request design tokens CATEGORY: Anything related to creation or maintenance of Gravity's design tokens labels May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design tokens CATEGORY: Anything related to creation or maintenance of Gravity's design tokens help wanted INVITATION: Indicates that a maintainer wants help on an issue or pull request 🌟 enhancement TYPE: Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

1 participant