Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter sentences by ID #47

Closed
7 tasks
Tracked by #44
kunnark opened this issue Oct 28, 2022 · 4 comments · Fixed by #87 or #112
Closed
7 tasks
Tracked by #44

Filter sentences by ID #47

kunnark opened this issue Oct 28, 2022 · 4 comments · Fixed by #87 or #112

Comments

@kunnark
Copy link
Contributor

kunnark commented Oct 28, 2022

AS A labeler
I WANT TO filter my sentences using sentence ID
IN ORDER TO select sentences that interests me.

Acceptance Criteria:

  • By default no filter is being applied.
  • If I click on a ‘Filter' then I can choose an interval of sentences I can filter ‘is between’.
  • If I click on a ‘Filter’ I can choose a filter that applies ‘bigger than’ > particular ID
  • If I click on a ‘Filter’ I can choose a filter that applies ‘smaller than’ < particular ID
  • I can also choose filters “>=” and “<=” on particular ID.
  • If I apply on a filter then the condition is being applied on sentence IDs and I can see the particular sentences I have chosen.
  • If I cancel the filter then the Default View is being applied, no filter is applied to the list of sentences.
@turnerrainer
Copy link
Contributor

@alimuhammadahmer @kunnark

  1. Is this purely a GUI development?
  2. ACs must contain all REST endpoints used, even if it only means GUI making requests to endpoints that will not be developed within this issue.

@alimuhammadahmer
Copy link
Contributor

Filtering/Sorting happens on Frontend. No Backend API is involved.

@kunnark kunnark moved this from 🏗 In progress to 📋 Backlog in Data Anonymizer Nov 11, 2022
@kunnark
Copy link
Contributor Author

kunnark commented Nov 11, 2022

@turnerrainer look at the @alimuhammadahmer 's comment. No backend involved.

@turnerrainer turnerrainer moved this from 📋 Backlog to 🔖 Ready in Data Anonymizer Nov 22, 2022
@alimuhammadahmer alimuhammadahmer linked a pull request Nov 23, 2022 that will close this issue
@alimuhammadahmer
Copy link
Contributor

@kunnark we changed this so that the filtering/sorting now happens on the BE. But the endpoint is the same (Ruuter GET /tasks?project={id} & ReSQL POST /get_corpora) as in #46. So I have linked that particular Pull Request to this story as well.

@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Data Anonymizer Jan 5, 2023
@alimuhammadahmer alimuhammadahmer linked a pull request Jan 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
3 participants