Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the exact same parameters as blurha.sh produces different results #4

Open
StainlessStlRat opened this issue Jun 15, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@StainlessStlRat
Copy link

StainlessStlRat commented Jun 15, 2023

Hello! I am using the library and have been for a while, but I've noticed for a while that it produces different (and arguably worse) results than the website implementation at blurha.sh

Please see my reference images. Any idea what could be going wrong?

Here is the generated blur hash and the difference in results:
LTIXH#ai5XRo0xRRnzR-4.M}-$V[

Screenshot 2023-06-14 at 11 14 18 PM Screenshot 2023-06-14 at 11 14 26 PM Screenshot 2023-06-14 at 11 14 34 PM
@StainlessStlRat
Copy link
Author

NOTE: The website and the encoding in go are using the same number of components on the same axes

@StainlessStlRat
Copy link
Author

Reference image for testing:
6056-1

@buckket buckket self-assigned this Oct 9, 2023
@buckket buckket added the bug Something isn't working label Oct 9, 2023
@StainlessStlRat
Copy link
Author

I think there is a subtle bug in multiplyBasisFunction, since in the C source code it's using 2D indexing and the go code is hand rolling the indices and such and other optimizations.

@StainlessStlRat
Copy link
Author

Any chance to take a crack at this?

@StainlessStlRat
Copy link
Author

Hello, just pinging you again in case you get the itch to take a crack and fix it! I'd love to regenerate all my site's blur hashes with the improved algorithm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants