Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to take a workflow by URL, not workflow descriptor #3849

Closed
geoffjentry opened this issue Jul 2, 2018 · 4 comments
Closed

Be able to take a workflow by URL, not workflow descriptor #3849

geoffjentry opened this issue Jul 2, 2018 · 4 comments
Assignees

Comments

@geoffjentry
Copy link
Collaborator

geoffjentry commented Jul 2, 2018

The cromwell API currently only allows users to submit the actual workflow file when they'd like to run a workflow. Also allow for a user to submit the URL pointing to the workflow file, which will then be consumed by Cromwell.

Edit: While the end goal is to not need a zip bundle for dependencies (as they can now be worked out via relative paths - cc @cjllanwarne ) -- that work is part of 3868.

NB: TBD (@ruchim ?) what should we do with file:// URLs? Perhaps a config option defaulting to off?

@geoffjentry geoffjentry added this to the Q3 - Support WES requirements for Oct 3 GA4GH demo milestone Jul 2, 2018
@geoffjentry
Copy link
Collaborator Author

Make sure that @cjllanwarne knows if you pick this up

@cjllanwarne cjllanwarne modified the milestones: Q3 - Support WES requirements for Oct 3 GA4GH demo, CUI Q3 - Relative imports just work Jul 5, 2018
@cjllanwarne
Copy link
Contributor

  • The "no zip bundle" set of import resolvers is probably the right one to use when trying to "resolve" the original file from String (unless a dependencies zip is also supplied?).
    • Side comment: should we therefore make the set of import resolvers to use Cromwell's responsibility? (right now every language factory comes up with its own set 😱)
  • We should try end up as similar to the WES equivalent as possible when adding this
    • To find out: is this just submit with workflowRoot + no workflowSource, or is it a separate endpoint?

@ruchim
Copy link
Contributor

ruchim commented Jul 11, 2018

@geoffjentry -- Yes, sounds good as a first pass to not support file://. If it's a local file, it should be submitted as expected under workflowSource

@cjllanwarne -- I believe its only the /submit or /workflow-runs post endpoint (in WES terminology) that uses the workflowSource & workflowRoot equivalents.

@ruchim
Copy link
Contributor

ruchim commented Jul 11, 2018

@cjllanwarne I changed the original content of this issue to separate out the work planned towards a CUI milestone. Let me know if something looks wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants