From 583e3fb0acf305765bbee62c8ba9f22779ff3e4f Mon Sep 17 00:00:00 2001 From: Tom Wiseman Date: Mon, 13 Nov 2023 14:15:42 -0500 Subject: [PATCH] shorten comment --- .../google/pipelines/common/MachineConstraints.scala | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/supportedBackends/google/pipelines/common/src/main/scala/cromwell/backend/google/pipelines/common/MachineConstraints.scala b/supportedBackends/google/pipelines/common/src/main/scala/cromwell/backend/google/pipelines/common/MachineConstraints.scala index 5fe4ba6b7f3..7e707f959e1 100644 --- a/supportedBackends/google/pipelines/common/src/main/scala/cromwell/backend/google/pipelines/common/MachineConstraints.scala +++ b/supportedBackends/google/pipelines/common/src/main/scala/cromwell/backend/google/pipelines/common/MachineConstraints.scala @@ -17,11 +17,11 @@ object MachineConstraints { s"predefined-$cpu-${memory.to(MemoryUnit.MB).amount.intValue()}" } else { // Users specify a CPU platform in their WDL, but GCP also needs to know which machine type to use. - // The below logic infers the machine type from the requested CPU. We're assuming that users want the newest - // "General Purpose" machine type that is compatible with the requested CPU. For example, if someone requests - // Intel Cascade Lake as their CPU platform, then infer the n2 machine type. AMD Rome -> n2d. + // The below logic infers the machine type from the requested CPU. // The heuristic we're using is: find the newest 'General Purpose' type that supports the given CPU. // https://cloud.google.com/compute/docs/machine-resource + // For example, if someone requests Intel Cascade Lake as their CPU platform, then infer the n2 machine type. + // Infer n2d from AMD Rome, etc. val customMachineType = cpuPlatformOption match { case Some(PipelinesApiRuntimeAttributes.CpuPlatformIntelIceLakeValue) => N2CustomMachineType