Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue(jQuery): Remove dependency on jQuery #13

Open
dylanvdmerwe opened this issue Jun 26, 2017 · 2 comments
Open

Issue(jQuery): Remove dependency on jQuery #13

dylanvdmerwe opened this issue Jun 26, 2017 · 2 comments

Comments

@dylanvdmerwe
Copy link

As an SDK, there should only be dependencies on libraries that are 1000% absolutely required.

There is no reason for jQuery to be depended on in this SDK. This is purely for DOM manipulation on the client and you are making an assumption about the use of the SDK.

jQuery should be removed, and all REST methods replaced with standard JavaScript XHR requests.
@dylanvdmerwe
Copy link
Author

Any feedback on this?

@ghost
Copy link

ghost commented Jul 28, 2017

Hi @dylanvdmerwe,

Thank you for noticing this. I'm adding a ticket to remove that dependency from the SDK. I hope it will be in by the next time we release a version.

Best regards.

@ghost ghost self-assigned this Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dylanvdmerwe