Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data loads seem much slower with Net Fetch #3105

Closed
philrz opened this issue Jun 19, 2024 · 1 comment · Fixed by #3106
Closed

Data loads seem much slower with Net Fetch #3105

philrz opened this issue Jun 19, 2024 · 1 comment · Fixed by #3106
Assignees
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Jun 19, 2024

tl;dr

Unfortunately, we failed to notice before the merge of #3069 that those changes there are making data loads much slower For instance, a load that previously took 5 seconds on my Intel Macbook now takes 3+ minutes.

Details

Repro is with Zui commit cc740ad.

The first video shows how things were performing better at commit 64f50eb right before the changes in #3069 merged. Here I'm doing a Quick Load of the ZNG-format zed-sample-data. As it shows, the data load takes about 5 seconds.

64f50eb.mp4

The second video is at commit cc740ad which is associated with the changes in #3069 that has the app using Net Fetch. As it shows, the same data load is now taking 3+ minutes.

cc740ad.mp4
@philrz philrz added the bug Something isn't working label Jun 19, 2024
@philrz
Copy link
Contributor Author

philrz commented Jun 20, 2024

Verified in Zui commit 508a6ae.

Verify.mp4

As shown in the attached video, the same data load now once again takes under 5 seconds to complete on my Macbook.

Thanks @jameskerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants