Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ycsb-0.9.0 missing cassandra2-binding #766

Closed
kruthar opened this issue Jun 15, 2016 · 11 comments
Closed

ycsb-0.9.0 missing cassandra2-binding #766

kruthar opened this issue Jun 15, 2016 · 11 comments

Comments

@kruthar
Copy link
Collaborator

kruthar commented Jun 15, 2016

Have seen this twice now. Is it worth trying to re-release ycsb-0.9.0? or should we just wait for ycsb-0.10.0. It seems sufficient to just point people at ycsb-0.8.0 for now.

@busbey
Copy link
Collaborator

busbey commented Jun 16, 2016

we should just do 0.10.0. I'll start the RC process this weekend.

@busbey
Copy link
Collaborator

busbey commented Jun 16, 2016

we should update the release notes on the 0.9.0 release though, since it calls out that binding as supported.

@busbey
Copy link
Collaborator

busbey commented Jun 16, 2016

just to confirm, is this that the binding-specific tarball is missing from the release (I notice that some others are as well, accumulo for example) or is the issue that the needed binary bits aren't in the everything-ycsb-binary-tarball?

@kruthar
Copy link
Collaborator Author

kruthar commented Jun 17, 2016

The cassandra2-binding directory is not present when you untar the ycsb-0.9.0.tar.gz which I think is what you are dubbing the 'everything-ycsb-binary-tarball'.

I was under the impression that only the bindings that were tested for that release were provided in single binding packages. That seems to be the case this time. So, it makes since that there is not a ycsb-cassandra2-0.9.0.tar.gz because it was not tested this time around.

@busbey
Copy link
Collaborator

busbey commented Jun 17, 2016

Anything in one of the "supported" categories is supposed to have a binding-specific tarball. If we just do those actually tested, folks will have to retest everything even when nonchanges should impact them to keep in "most blessed" status.

@busbey
Copy link
Collaborator

busbey commented Jun 17, 2016

Does the YCSB binary tarball contain the cassandra2 binding in the current master branch?

@kruthar
Copy link
Collaborator Author

kruthar commented Jun 17, 2016

Do you mean is it present if I just try a mvn package on master right now? I am not sure, I'm failing the Accumulo tests because Zookeeper isn't starting. Is it supposed to kick off a full test of Accumulo and everything when you build on a laptop? (as opposed to builds done on travis).

@busbey
Copy link
Collaborator

busbey commented Jun 22, 2016

Yeah, I think Accumulo tests get included by default in our build. Lemme check before cutting a branch for #772

@busbey
Copy link
Collaborator

busbey commented Jun 22, 2016

I updated the release notes for 0.9.0 to call out this issue.

@busbey
Copy link
Collaborator

busbey commented Jun 22, 2016

okay, looks like it's present in master:

Busbey-MBA:YCSB busbey$ tar tzf distribution/target/ycsb-0.10.0-SNAPSHOT.tar.gz | grep cassandra2-binding
ycsb-0.10.0-SNAPSHOT/cassandra2-binding/README.md
ycsb-0.10.0-SNAPSHOT/cassandra2-binding/lib/
ycsb-0.10.0-SNAPSHOT/cassandra2-binding/lib/cassandra-driver-core-3.0.0.jar
ycsb-0.10.0-SNAPSHOT/cassandra2-binding/lib/guava-16.0.1.jar
ycsb-0.10.0-SNAPSHOT/cassandra2-binding/lib/metrics-core-3.1.2.jar
ycsb-0.10.0-SNAPSHOT/cassandra2-binding/lib/netty-buffer-4.0.33.Final.jar
ycsb-0.10.0-SNAPSHOT/cassandra2-binding/lib/netty-codec-4.0.33.Final.jar
ycsb-0.10.0-SNAPSHOT/cassandra2-binding/lib/netty-common-4.0.33.Final.jar
ycsb-0.10.0-SNAPSHOT/cassandra2-binding/lib/netty-handler-4.0.33.Final.jar
ycsb-0.10.0-SNAPSHOT/cassandra2-binding/lib/netty-transport-4.0.33.Final.jar
ycsb-0.10.0-SNAPSHOT/cassandra2-binding/lib/slf4j-api-1.6.4.jar
ycsb-0.10.0-SNAPSHOT/cassandra2-binding/lib/cassandra2-binding-0.10.0-SNAPSHOT.jar

@busbey busbey mentioned this issue Jun 22, 2016
@busbey
Copy link
Collaborator

busbey commented Aug 2, 2016

closed in #772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants