-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.34.0: pytest is failing in some units #872
Comments
Thanks for figuring out that there is already a fix in the repo. @vermeeren - are you in position to do a release at some point soon? |
Just tested that commit and indeed it fixes fails in some units + PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-breathe-4.34.0-4.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-breathe-4.34.0-4.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.16, pytest-7.2.0, pluggy-1.0.0
rootdir: /home/tkloczko/rpmbuild/BUILD/breathe-4.34.0
collected 21 items
tests/test_renderer.py .................. [ 85%]
tests/test_utils.py ... [100%]
============================================================================= warnings summary =============================================================================
tests/test_renderer.py: 18 warnings
/home/tkloczko/rpmbuild/BUILD/breathe-4.34.0/tests/test_renderer.py:128: DeprecationWarning: The frontend.OptionParser class will be replaced by a subclass of argparse.ArgumentParser in Docutils 0.21 or later.
settings = frontend.OptionParser(components=(parsers.rst.Parser,)).get_default_values()
tests/test_renderer.py: 1224 warnings
/usr/lib64/python3.8/optparse.py:1000: DeprecationWarning: The frontend.Option class will be removed in Docutils 0.21 or later.
option = self.option_class(*args, **kwargs)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
==================================================================== 21 passed, 1242 warnings in 1.19s ===================================================================== Thank you 👍 |
@michaeljones Apologies for the delays recently. Checking quick today I do notice the CI is failing which is typically something I'd like to see passing before making a release. I'll try to check the remainder of notifications within a few days and if it the CI is green I'll fix a release. If there's anything specific you know of feel free to let me know anytime. Cheers |
Fair point. I'll try to poke around and get it into shape. My enthusiasm comes and goes but I have a bit of energy for it at the moment. |
This was fixed by #865 and a release v4.35.0 has been made quite a while ago. Thanks to all for the help! |
I'm packaging your module as an rpm package so I'm using the typical PEP517 based build, install and test cycle used on building packages from non-root account.
python3 -sBm build -w --no-isolation
build
with--no-isolation
I'm using during all processes only locally installed modulesHere is pytest output:
Here is list of installed modules in build env
The text was updated successfully, but these errors were encountered: