Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

private tab history shouldn't appear in autocomplete #966

Closed
diracdeltas opened this issue Mar 1, 2016 · 6 comments
Closed

private tab history shouldn't appear in autocomplete #966

diracdeltas opened this issue Mar 1, 2016 · 6 comments

Comments

@diracdeltas
Copy link
Member

If you open a private tab and visit a site, the site will appear in the urlbar autocomplete in non-private tabs as well. It also appears in the autocomplete if you restart the browser, which suggests the private tab URL is getting written to disk.

@bbondy bbondy added this to the 0.8.0 milestone Mar 1, 2016
@bbondy
Copy link
Member

bbondy commented Mar 1, 2016

marked for 0.8

@diracdeltas
Copy link
Member Author

👍

@diracdeltas
Copy link
Member Author

I can't seem to repro getting a private tab URL in the autocomplete after browser restart, so I think that part was a fluke.

@bbondy
Copy link
Member

bbondy commented Mar 1, 2016

Surprised because of this check

if (!this.props.frame.get('isPrivate') && (protocol === 'http:' || protocol === 'https:')) {

@diracdeltas
Copy link
Member Author

My bad, it looks like it was appearing in autocomplete because it was a currently open tab, not because of history.

@diracdeltas
Copy link
Member Author

dupe of #140

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants