Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Enable fingerprinting protection by default #8142

Closed
Jacalz opened this issue Apr 9, 2017 · 6 comments
Closed

Enable fingerprinting protection by default #8142

Jacalz opened this issue Apr 9, 2017 · 6 comments

Comments

@Jacalz
Copy link
Contributor

Jacalz commented Apr 9, 2017

I would suggest that you enable fingerprintinge protection by default because I rarely ever see any site breaking and that is after a couple of months with brave 👍
I have seen that Sketchfab breaks with it enabled but that is the only thing, the thread from the community can be found here:
https://community.brave.com/t/sketchfab-not-loading-3dmodels-with-fingerprinting-protection-on/1752/3

And here is a github issue with logged problems:
#2965

As Luke Mulks said, it might be different in different regions but it works great here in Sweden 🇸🇪

@luixxiul
Copy link
Contributor

luixxiul commented Apr 9, 2017

the thing is that there is no clear indication such as messageBox when something (eg on https://spreadsheets.google.com) is broken due to fingerprinting protection. A browser guide tour would help here.

@lukemulks
Copy link
Collaborator

+1 for browser guide tour.

It would be interesting to run some checks against sites that had breakage with FP enabled, and see if the issues remain, or if they may have been resolved over time.

@luixxiul - do you know if we had some specific domains where FP was causing breakage? If not, no worries, I can ask around and see too.

Thanks for submitting @Jacalz, regardless of whether this is enabled by default, it's really good to hear that site breakage isn't being observed in your region w/FP enabled.

@srirambv
Copy link
Collaborator

#4621(#3723) should help in notifying users about FP breaking sites. I think it would be nice to show a message box when there is a FP method loaded on a site to warn users that the page might not work properly.
image

cc: @bradleyrichter

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 10, 2017

@srirambv we need to be carful here, because personally I have fingerprint always on and if I would get this notification every single time that FP was blocked I would rage quite Brave 😄

@srirambv
Copy link
Collaborator

@NejcZdovc I have it too but I think thats a little trouble have to go for the extra protection. 😆 But since its the js popup the second one would show to disable the notification for that site.

@diracdeltas
Copy link
Member

This has also been proposed by @BrendanEich in Slack. Once #2965 (comment) (whitelist of sites known to break with FP enabled) is done, the notification could potentially be infrequent enough that it isn't annoying.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants