Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Able to setup sync with a deleted profile #7341

Closed
srirambv opened this issue Feb 21, 2017 · 2 comments
Closed

Able to setup sync with a deleted profile #7341

srirambv opened this issue Feb 21, 2017 · 2 comments

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Sync profile is set when an old sync code is used

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.13.5
    rev 59a41eb

  • Steps to reproduce:

    1. Setup sync profile on device 1(pyramid 0)
    2. Copy the secret code generated for that profile
    3. Delete the user profile on device 1(pyramid 0)
    4. On device 2(pyramid 1) setup sync using I have an existing sync code
    5. Enter the secret code copied in step 2
    6. Sync profile is setup but nothing happens as pyramid 0 is deleted
  • Actual result:
    Able to sync to a deleted profile

  • Expected result:
    Should not be allowed to sync to a deleted profile

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    N/A

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
    cc: @ayumi @diracdeltas

@diracdeltas
Copy link
Member

This is expected behavior. You have to explicitly click a 'delete this sync profile' button (not yet implemented) to delete the profile.

@diracdeltas
Copy link
Member

closing in favor of brave/sync#51

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants