Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor textarea with Aphrodite into TextArea #7163

Closed
luixxiul opened this issue Feb 10, 2017 · 4 comments
Closed

Refactor textarea with Aphrodite into TextArea #7163

luixxiul opened this issue Feb 10, 2017 · 4 comments
Assignees
@luixxiul
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/include
Milestone
0.13.5

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Feb 10, 2017 •
edited by bsclifton
Loading

Test Plan

  1. Open about:adblock
  2. Input some strings inside the textarea
  3. Make sure the font size is set to 14.5px
  4. Make sure 10px margins exist on the top and the bottom of the textarea
  5. Open about:styles
  6. Make sure <TextForm> and <DefaultTextForm> are correctly displayed

Original issue details

Describe the issue you encountered:
#6851 (comment)

The font-size should be 14.5px based on https://github.com/brave/browser-laptop/pull/6689/files#diff-fa59d1e0221a5bee94fd2abd9b96dcfdR17

Also the textarea should be updated to an Aphrodite component. And I'm creating it.
@luixxiul luixxiul self-assigned this Feb 10, 2017
@luixxiul
Copy link
Contributor Author

I will also create <SyncTextArea> based on https://github.com/brave/browser-laptop/pull/7152/files#diff-4b50ff14dadc9756719a577a72f520d6R1562 / CC: @ayumi

@luixxiul luixxiul mentioned this issue Feb 10, 2017
Merged
4 tasks
@luixxiul
Copy link
Contributor Author

luixxiul commented Feb 10, 2017 •
edited
Loading

I added <SyncTextArea> with 864f561. It is based on 4a8bd86 of #7165.

screenshot 2017-02-10 23 59 56

I will create an PR after #7165 is merged.

@bsclifton
Copy link
Member

Looks nice! Great work, @luixxiul 😄

@cezaraugusto
Copy link
Contributor

aphrodite_all_the_things

@bsclifton bsclifton added this to the 0.13.4 milestone Feb 12, 2017
@luixxiul luixxiul mentioned this issue Feb 25, 2017
Closed
This was referenced Feb 26, 2017
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 3, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/include
Projects
None yet
Milestone
0.13.5
Development

No branches or pull requests
5 participants
@alexwykoff @luixxiul @cezaraugusto @bsclifton @srirambv