Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed button alignment on the notification bar #6749

Closed
srirambv opened this issue Jan 19, 2017 · 3 comments
Closed

Fixed button alignment on the notification bar #6749

srirambv opened this issue Jan 19, 2017 · 3 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jan 19, 2017

Test plan

#7831 (comment)


Did you search for similar issues before submitting this one?

Describe the issue you encountered:
Language restart buttons are way big for Japanese

Expected behavior:
The button size should be same for all languages

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.0
    rev c60b783

  • Steps to reproduce:

    1. Do a clean install of 0.13.0 preview 10
    2. Change browser language from English to Japanese
    3. Notice the size of the buttons on the notification bar
      image
    4. Restart the browser to make the language change
    5. Change language from Japanese to any other language to trigger the notification bar
    6. The size of the buttons is big
      image
  • Extra QA steps:

    1. Do a clean install of 0.13.0 preview 10
    2. Change browser language from English to Japanese
    3. Notice the size of the buttons on the notification bar
    4. Restart the browser to make the language change
    5. Change language from Japanese to any other language to trigger the notification bar
    6. Ensure the button size is same as in step 3
  • Screenshot if needed:

  • Any related issues:

@luixxiul
Copy link
Contributor

This may be due to the font which is installed on your PC. You would need to install several Japanese fonts. On my environment I haven't noticed the issue.

I will try later on my VM in Japanese and will let you know this should be wontfix.

@luixxiul
Copy link
Contributor

luixxiul commented Jan 20, 2017

This is essentially the same issue with #5799 (comment)

clipboard01

clipboard01

The issue here is not the font size, but the one which is common among the buttons aligned with float: right.

With some additional modifications the buttons can be aligned at the center, setting margin-top and margin-bottom on the buttons like this:

clipboard01

Note that the font-family applied above is Meiryo.

@luixxiul
Copy link
Contributor

I'll work on it later

@luixxiul luixxiul changed the title Language restart buttons are way big for Japanese Align buttons on the notification bar w/o float:right Jan 22, 2017
@luixxiul luixxiul added polish Nice to have — usually related to front-end/visual tasks. and removed l10n labels Jan 23, 2017
@luixxiul luixxiul modified the milestones: 0.13.2, 0.13.1 Jan 27, 2017
@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@luixxiul luixxiul added this to the 0.14.0 milestone Mar 24, 2017
@luixxiul luixxiul changed the title Align buttons on the notification bar w/o float:right Align buttons on the notification bar w/o float:right Mar 24, 2017
@alexwykoff alexwykoff changed the title Align buttons on the notification bar w/o float:right Fixed buttons alignment on the notification bar Mar 28, 2017
@alexwykoff alexwykoff changed the title Fixed buttons alignment on the notification bar Fixed button alignment on the notification bar Mar 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants