Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Edit Bookmark close icon needs hover color #5953

Closed
getsetbro opened this issue Nov 30, 2016 · 2 comments
Closed

Edit Bookmark close icon needs hover color #5953

getsetbro opened this issue Nov 30, 2016 · 2 comments
Labels
design A design change, especially one which needs input from the design team. QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone

Comments

@getsetbro
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
The CLOSE icon has no hover effect.
Expected behavior:
"For the X, it should be @buttonColor when idle and #000 (black) when hovered."

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version:
    0.12.10

  • Steps to reproduce:
    1.
    2.
    3.

  • Screenshot if needed:
    gif

  • Any related issues:

@bsclifton bsclifton added this to the 0.13.0 milestone Dec 1, 2016
@bsclifton bsclifton added the design A design change, especially one which needs input from the design team. label Dec 1, 2016
@bsclifton
Copy link
Member

closed via #5954

@getsetbro for future reference, you can use self-closing keywords in the commit and GitHub will auto close the issue on merge

Commit would just need to have text like "Fixes #5954" 😄

@luixxiul
Copy link
Contributor

Test plan: #5954 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Development

No branches or pull requests

4 participants