Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

delete folder cause stack overflow #5357

Closed
darkdh opened this issue Nov 2, 2016 · 1 comment · Fixed by #5361
Closed

delete folder cause stack overflow #5357

darkdh opened this issue Nov 2, 2016 · 1 comment · Fixed by #5361

Comments

@darkdh
Copy link
Member

darkdh commented Nov 2, 2016

version: master 9566bcd

STR:

  1. Make sure you have clean session
  2. new folder “123” under toolbar
  3. new folder “456” under “123”
  4. delete folder “123"

there will be a infinite recursive call in removeSite due to parentFolderId is its folderId

@darkdh darkdh added this to the 0.12.8dev milestone Nov 2, 2016
@bsclifton bsclifton self-assigned this Nov 2, 2016
@bsclifton
Copy link
Member

this shouldn't be present in 0.12.8, since the about:newtab commits were not included

Root cause was found by @darkdh to be here:
dbe041d#diff-23ca389e2bcb77191b5a9c10900eb3a3R462

Fix in progress...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants