Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Visiting http://expressjs.com/ causes Brave to crash #5270

Closed
alexwykoff opened this issue Oct 30, 2016 · 6 comments
Closed

Visiting http://expressjs.com/ causes Brave to crash #5270

alexwykoff opened this issue Oct 30, 2016 · 6 comments

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
A user from support has reported that attempting to visit http://expressjs.com/ via a Google search causes Brave to crash.

Expected behavior:
Brave should visit the site normally.

@privatzee
Copy link
Contributor

privatzee commented Oct 30, 2016

Same as: TripAdvisor crashes Brave #5264

Brave doesn't get as far as DNS lookup on this one, either. You can crash without any internet connection, so it's not the content. Now, this case demonstrates that there's nothing unique about the domain name which causes the crash. What remains?

Some regexp gone awry on domain names?

@bbondy
Copy link
Member

bbondy commented Oct 30, 2016

@bbondy bbondy self-assigned this Oct 30, 2016
@bbondy
Copy link
Member

bbondy commented Oct 30, 2016

I'm taking a look, it looks like a crash in adblock, probably something always there but being hit because new rules in an adblock list update. Might be solveable with a new list update without a release, will know after investigating.

@privatzee
Copy link
Contributor

privatzee commented Oct 30, 2016

sweclockers.com #5273 is not the same as the others that crash instantly.

edit: not exactly the same anyway, as the onset is different but the end cause may be the same

@bbondy
Copy link
Member

bbondy commented Oct 31, 2016

fixed, bad handling for host anchored filters with no host, people will get an update for the dat file without needing to do a release within an hour. Also I’ll fix it so we handle that better without crashing separate of uploading the data files in case it happens again.

@bbondy
Copy link
Member

bbondy commented Oct 31, 2016

General problem fixed moving forward here:
brave-experiments/ad-block@c42046d

Adblock data files also patched so there's no immediate need for a release. People will get it within a day. By the way in 0.12.8 we made the checks more frequent than every day to every 2h.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants