-
Notifications
You must be signed in to change notification settings - Fork 971
Visiting http://expressjs.com/ causes Brave to crash #5270
Comments
Same as: TripAdvisor crashes Brave #5264 Brave doesn't get as far as DNS lookup on this one, either. You can crash without any internet connection, so it's not the content. Now, this case demonstrates that there's nothing unique about the domain name which causes the crash. What remains? Some regexp gone awry on domain names? |
I'm taking a look, it looks like a crash in adblock, probably something always there but being hit because new rules in an adblock list update. Might be solveable with a new list update without a release, will know after investigating. |
sweclockers.com #5273 is not the same as the others that crash instantly. edit: not exactly the same anyway, as the onset is different but the end cause may be the same |
fixed, bad handling for host anchored filters with no host, people will get an update for the dat file without needing to do a release within an hour. Also I’ll fix it so we handle that better without crashing separate of uploading the data files in case it happens again. |
General problem fixed moving forward here: Adblock data files also patched so there's no immediate need for a release. People will get it within a day. By the way in 0.12.8 we made the checks more frequent than every day to every 2h. |
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
A user from support has reported that attempting to visit http://expressjs.com/ via a Google search causes Brave to crash.
Expected behavior:
Brave should visit the site normally.
0.12.7
Reproduced on my OS X machine.
https://linkbubble.zendesk.com/agent/tickets/6414
The text was updated successfully, but these errors were encountered: