pinned tabs don't load correctly on new windows

[bridiver]

Ideally the pinned tab should literally move from window to window and maintain state, but that will require guest view from #137 but right now if you open a new window the page doesn't load correctly
Steps to reproduce:

1. Open cnn.com
2. Pin the tab
3. Open a new window
   The pinned tab will be missing css, etc...

[bbondy]

In the current design each window loads a separate copy of the page. I agree this new design would be more ideal though.

Pls confirm the page does load, just a different copy right now for you. If not let me know what your pinned site is.

[bridiver]

it doesn't load in the other window for me, at least not completely. Appears to be missing images, css, etc.. also seems to trigger this when closing

Uncaught Exception:
Error: Object has been destroyed
    at Error (native)
    at Function.<anonymous> (/Users/bjohnson/Documents/brave/browser-electron/app/filtering.js:32:12)

[bbondy]

Loads a second copy of the site for me, not sure what that error is but could be related. Could you give an exact url of the site you are pinning? I'm pinning apple.com.

[bridiver]

apple.com also works for me, but facebook.com fails to load completely

[bbondy]

who needs facebook ;)

[bbondy]

facebook also working for me :(

[luixxiul]

Was this fixed?

[bridiver]

I still see an issue with Facebook
After pinning tab

Pinned tab in new window

[luixxiul]

Um, on Windows 10 it cannot be reproduced. I pinned facebook.com and opened a new window, but pinned facebook was displayed correctly. OS X only bug maybe?

[bridiver]

fixed by 6e307bc