Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fingerprinting Protection per site setting is not synced appropriately #14343

Closed
LaurenWags opened this issue Jun 6, 2018 · 0 comments
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jun 6, 2018

Description

If you have sync enabled and adjust the Fingerprint Protection setting for a specific site, that setting may not be synced properly. Block 3rd Party Fingerprinting and Allow all fingerprinting both send false when syncing. Block all fingerprinting sends true.

Steps to Reproduce

  1. Launch Brave and enable Sync.
  2. Open sync background page.
  3. Visit a site and adjust the 'Fingerprinting Protection' setting for this site to 'Block all fingerprinting.
  4. Look at background page. You will see "fingerprintingProtection":true in the sending record.
  5. Adjust the setting to be 'Allow all fingerprinting`.
  6. Look at background page. You will see "fingerprintingProtection":false in the sending record.
  7. Adjust the setting to be 'Block 3rd Party Fingerprinting.

Actual result:
You will see "fingerprintingProtection":false in the sending record.

Expected result:
Syncing the Fingerprinting Protection setting should differentiate between the 3 options.

Reproduces how often:
Easily

Brave Version

about:brave info:
0.22.807

Reproducible on current live release:
Yes

Additional Information

Probably introduced with #9029 where the 3rd Fingerprinting Option was implemented.

When this is fixed, should be tested by having another machine join the sync group and verify option is set appropriately on the second machine.

@LaurenWags LaurenWags added this to the Backlog (Prioritized) milestone Jun 6, 2018
@bsclifton bsclifton added the stale label Sep 9, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants