From a21be2b9ed430c5301c696d88723171a1d1d3d7d Mon Sep 17 00:00:00 2001 From: Anthony Tseng Date: Thu, 29 Sep 2016 11:53:14 +0800 Subject: [PATCH] Supersede cd3dd7829731f6e36eb70ac1ac4397598e615153 by "scroll-touch-edge" Auditors: @bbondy Test Plan: 1. Open google search result 2. Click any link and back to the search result 3. Make the window smaller by open dev console (shift + f8) 4. Make sure you can horizontally scroll the page 5. Make sure you can swipe back/forward when you scroll to the edge --- .../brave/content/scripts/inputHandler.js | 14 -------------- js/actions/webviewActions.js | 17 ----------------- js/components/frame.js | 6 ------ js/components/main.js | 19 ++----------------- js/constants/messages.js | 4 ---- 5 files changed, 2 insertions(+), 58 deletions(-) diff --git a/app/extensions/brave/content/scripts/inputHandler.js b/app/extensions/brave/content/scripts/inputHandler.js index 55c1ca2cee8..e67c325e88c 100644 --- a/app/extensions/brave/content/scripts/inputHandler.js +++ b/app/extensions/brave/content/scripts/inputHandler.js @@ -156,17 +156,3 @@ document.addEventListener('keydown', (e /*: Event*/) => { break } }) - -chrome.ipc.on('check-swipe-back', (e) => { - if (document.scrollingElement.scrollLeft === 0) { - chrome.ipc.sendToHost('can-swipe-back') - } -}) - -chrome.ipc.on('check-swipe-forward', (e) => { - const scrollEle = document.scrollingElement - if (scrollEle.scrollLeft === 0 || - scrollEle.scrollLeft === (scrollEle.scrollWidth - scrollEle.clientWidth)) { - chrome.ipc.sendToHost('can-swipe-forward') - } -}) diff --git a/js/actions/webviewActions.js b/js/actions/webviewActions.js index 0ae2afa74df..419dcf01ec0 100644 --- a/js/actions/webviewActions.js +++ b/js/actions/webviewActions.js @@ -4,8 +4,6 @@ 'use strict' -const messages = require('../constants/messages.js') - const getWebview = () => document.querySelector('.frameWrapper.isActive webview') @@ -53,21 +51,6 @@ const webviewActions = { } }, - /** - * Check two-finger gesture swipe back/forward ability - * @param {bool} back - true for back, false for forward - */ - checkSwipe: function (back) { - const webview = getWebview() - if (webview) { - if (back) { - webview.send(messages.CHECK_SWIPE_BACK) - } else { - webview.send(messages.CHECK_SWIPE_FORWARD) - } - } - }, - /** * Set/unset webkit fullscreen status * @param {Boolean} isFullScreen - fullscreen state to go to diff --git a/js/components/frame.js b/js/components/frame.js index cca7251f82f..f13f6a276fd 100644 --- a/js/components/frame.js +++ b/js/components/frame.js @@ -753,12 +753,6 @@ class Frame extends ImmutableComponent { } } break - case messages.CAN_SWIPE_BACK: - currentWindow.webContents.send(messages.CAN_SWIPE_BACK) - break - case messages.CAN_SWIPE_FORWARD: - currentWindow.webContents.send(messages.CAN_SWIPE_FORWARD) - break case messages.CLEAR_BROWSING_DATA_NOW: method = (clearBrowsingDataDetail) => windowActions.setClearBrowsingDataDetail(clearBrowsingDataDetail) diff --git a/js/components/main.js b/js/components/main.js index 616a2839d01..9032c60768b 100644 --- a/js/components/main.js +++ b/js/components/main.js @@ -187,8 +187,6 @@ class Main extends ImmutableComponent { // Navigates back/forward on macOS two-finger swipe var trackingFingers = false var swipeGesture = false - var canSwipeBack = false - var canSwipeForward = false var isSwipeOnEdge = false var deltaX = 0 var deltaY = 0 @@ -200,11 +198,6 @@ class Main extends ImmutableComponent { deltaX = deltaX + e.deltaX deltaY = deltaY + e.deltaY time = (new Date()).getTime() - startTime - if (deltaX > 0) { - webviewActions.checkSwipe(false) - } else if (deltaX < 0) { - webviewActions.checkSwipe(true) - } } }) ipc.on(messages.DEBUG_REACT_PROFILE, (e, args) => { @@ -233,12 +226,6 @@ class Main extends ImmutableComponent { }, true) } }) - ipc.on(messages.CAN_SWIPE_BACK, (e) => { - canSwipeBack = true - }) - ipc.on(messages.CAN_SWIPE_FORWARD, (e) => { - canSwipeForward = true - }) ipc.on(messages.ENABLE_SWIPE_GESTURE, (e) => { swipeGesture = true }) @@ -255,15 +242,13 @@ class Main extends ImmutableComponent { }) ipc.on('scroll-touch-end', function () { if (time > 50 && trackingFingers && Math.abs(deltaY) < 50 && isSwipeOnEdge) { - if (deltaX > 70 && canSwipeForward) { + if (deltaX > 70) { ipc.emit(messages.SHORTCUT_ACTIVE_FRAME_FORWARD) - } else if (deltaX < -70 && canSwipeBack) { + } else if (deltaX < -70) { ipc.emit(messages.SHORTCUT_ACTIVE_FRAME_BACK) } } trackingFingers = false - canSwipeBack = false - canSwipeForward = false deltaX = 0 deltaY = 0 startTime = 0 diff --git a/js/constants/messages.js b/js/constants/messages.js index 0a5e95692ee..3de2f6fa5d5 100644 --- a/js/constants/messages.js +++ b/js/constants/messages.js @@ -75,10 +75,6 @@ const messages = { GO_BACK: _, GO_FORWARD: _, RELOAD: _, - CAN_SWIPE_BACK: _, - CAN_SWIPE_FORWARD: _, - CHECK_SWIPE_BACK: _, - CHECK_SWIPE_FORWARD: _, ENABLE_SWIPE_GESTURE: _, DISABLE_SWIPE_GESTURE: _, SHOW_FLASH_NOTIFICATION: _,