From 62665a5518d1c2c767365bbfc5441e05444788a7 Mon Sep 17 00:00:00 2001 From: "Brian R. Bondy" Date: Sun, 9 Apr 2017 23:01:11 -0400 Subject: [PATCH] UrlBarIcon drag to bookmark fix Fix #8151 Test plan: npm run test -- --grep="UrlBarIcon" I don't think there's a good way to add automated tests for drag and drop yet --- app/renderer/components/urlBarIcon.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/renderer/components/urlBarIcon.js b/app/renderer/components/urlBarIcon.js index d075a6d76da..c4a5a4f70a4 100644 --- a/app/renderer/components/urlBarIcon.js +++ b/app/renderer/components/urlBarIcon.js @@ -10,6 +10,8 @@ const dragTypes = require('../../../js/constants/dragTypes') const dndData = require('../../../js/dndData') const {isSourceAboutUrl} = require('../../../js/lib/appUrlUtil') const {isPotentialPhishingUrl} = require('../../../js/lib/urlutil') +const windowStore = require('../../../js/stores/windowStore') +const {getActiveFrame} = require('../../../js/state/frameStateUtil') const searchIconSize = 16 class UrlBarIcon extends ImmutableComponent { @@ -89,7 +91,8 @@ class UrlBarIcon extends ImmutableComponent { } onDragStart (e) { dndData.setupDataTransferURL(e.dataTransfer, this.props.location, this.props.title) - dndData.setupDataTransferBraveData(e.dataTransfer, dragTypes.TAB, this.activeFrame) + const activeFrame = getActiveFrame(windowStore.state) + dndData.setupDataTransferBraveData(e.dataTransfer, dragTypes.TAB, activeFrame) } render () { // allow click and drag (unless tab is showing a message box)