Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #5373: de amp debounce #5536

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Fix #5373: de amp debounce #5536

merged 2 commits into from
Jul 26, 2022

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Jun 17, 2022 •
edited by iccub
Loading

Summary of Changes

This pull request fixes #5373

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Test plan can be found in the original android ticket:
brave/brave-browser#23121

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

Links

Sec review: https://github.com/brave/security/issues/925

@cuba cuba force-pushed the js/5373-de-amp-debounce branch 5 times, most recently from 435ad9c to 34d9139 Compare June 21, 2022 16:31
@cuba cuba requested a review from a team June 21, 2022 16:44
@cuba cuba marked this pull request as ready for review June 21, 2022 16:45
@cuba cuba force-pushed the js/5373-de-amp-debounce branch 4 times, most recently from bad7c5f to 1e5423f Compare June 22, 2022 15:16
@cuba cuba force-pushed the js/5373-de-amp-debounce branch from 1e5423f to 47ef512 Compare June 22, 2022 19:18
fmarier
fmarier suggested changes Jun 24, 2022
View reviewed changes
@cuba cuba force-pushed the js/5373-de-amp-debounce branch 5 times, most recently from 1e0ff20 to 7daa62c Compare July 8, 2022 16:51
@cuba cuba force-pushed the js/5373-de-amp-debounce branch 2 times, most recently from 5ff70f7 to af8ed6b Compare July 8, 2022 19:15
@iccub iccub requested a review from fmarier July 11, 2022 19:23
@cuba cuba force-pushed the js/5373-de-amp-debounce branch 2 times, most recently from 9b1ad98 to b95f614 Compare July 11, 2022 20:29
@cuba cuba force-pushed the js/5373-de-amp-debounce branch 2 times, most recently from 3051317 to e6c7263 Compare July 11, 2022 20:52
fmarier
fmarier approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NSURL(idnstring) and test changes look good to me.

@cuba cuba force-pushed the js/5373-de-amp-debounce branch from e6c7263 to 54bd010 Compare July 12, 2022 21:04
@iccub iccub force-pushed the js/5373-de-amp-debounce branch from 54bd010 to 9afe55e Compare July 20, 2022 13:45
@cuba cuba force-pushed the js/5373-de-amp-debounce branch 2 times, most recently from fdc7972 to 0989ed4 Compare July 21, 2022 22:17
@cuba cuba changed the title Js/5373 de amp debounce Fix #5373: de amp debounce Jul 25, 2022
@iccub iccub force-pushed the js/5373-de-amp-debounce branch from 0989ed4 to 2028401 Compare July 26, 2022 14:34
@iccub iccub added this to the 1.42 milestone Jul 26, 2022
@iccub iccub merged commit 1dd261c into development Jul 26, 2022
@iccub iccub deleted the js/5373-de-amp-debounce branch July 26, 2022 17:32
@iccub iccub removed the enhancement label Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylehickinson kylehickinson kylehickinson left review comments

@fmarier fmarier fmarier approved these changes

@Brandon-T Brandon-T Brandon-T approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.42
Development

Successfully merging this pull request may close these issues.

Add debounce de-amp rules
5 participants
@cuba @fmarier @kylehickinson @Brandon-T @iccub