Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Favorites overlay leaks through the status bar #7898

Closed
iccub opened this issue Aug 18, 2023 · 2 comments
Closed

Favorites overlay leaks through the status bar #7898

iccub opened this issue Aug 18, 2023 · 2 comments
Labels
bug Epic: UI/UX QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.60

Comments

@iccub
Copy link
Contributor

iccub commented Aug 18, 2023

See https://community.brave.com/t/brave-favourites-favorites-page-is-this-normal/501317
@kylehickinson
Copy link
Collaborator

This seems to be have been fixed by one of the latest PRs, please re-test in 1.59

@kylehickinson kylehickinson added this to the 1.59 milestone Oct 23, 2023
@hffvld
Copy link
Collaborator

hffvld commented Nov 7, 2023

Verified on iPhone 14using version(s):

Device/OS: iPhone 14 / iOS 17.1
Brave build: 1.60 (23.11.4.14)
BraveCore: 1.60.105 (119.0.6045.59)

STEPS:

  1. Launch Brave
  2. Add few any websites to a favorite, so their favicons will be shown on NTP
  3. Scroll through favicons > Verify

ACTUAL RESULTS:

  • Verified that favicons are not overlaying through the status bar
Reproduced Fixed
1 2

@Uni-verse Uni-verse mentioned this issue Dec 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Epic: UI/UX QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.60
Development

No branches or pull requests
4 participants
@kylehickinson @iccub @Uni-verse @hffvld