This repository has been archived by the owner on Jun 6, 2019. It is now read-only.
Add scope to methods which modify content settings #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#1198
Known issue: content settings from public windows are NOT inherited into private windows. ex: if you visit https://www.dailymail.co.uk and disable shields in a tab and then open a new private window, that shields off setting is not propagated to the private window. This is a separate bug that needs to be tracked which was not caused by this PR.
If this PR is approved/merged, I will create an issue to track that problem
Reviewer setup steps
brave-browser
(master branch)package.json
to have branchcontent-settings-add-scope
forbrave-core
npm run init
ornpm run sync -- --all
npm run build
npm start
Test plan
Part 1: Test that shields down/up works fine
Part 2: test other content_settings
Ad Control
,Cookie Control
,Fingerprinting Protection
,HTTPS Everywhere
,Block Scripts
)Part 3: verify that settings are NOT persisted